Remove Realm Plugin setting the bytecode target to 1.8 #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
requested review from
rorbech and
clementetb
and removed request for
rorbech
rorbech
approved these changes
Sep 12, 2023
added 2 commits
September 12, 2023 16:51
Add support for Java 17 when using ktlintFormat.
# Conflicts: # buildSrc/src/main/kotlin/Config.kt
nhachicha
reviewed
Sep 13, 2023
| kotlinOptions.jvmTarget = Versions.jvmTarget | ||
| } | ||
| } | ||
| jvm() |
There was a problem hiding this comment.
Is it getting the correct target default?
There was a problem hiding this comment.
Yes, it is being set by https://github.com/realm/realm-kotlin/pull/1514/files#diff-5ea5ab9e6b701c3d35d3fd2fad81ff600102db520494994cc7448e7d3e032d9dR32 ... which now controls everything.
| @@ -57,6 +57,7 @@ allprojects { | |||
|
|
|||
| description = "Check Kotlin code style." | |||
| classpath = ktlint | |||
| jvmArgs = listOf("--add-opens=java.base/java.lang=ALL-UNNAMED") | |||
There was a problem hiding this comment.
why do we need this? for refelction?
There was a problem hiding this comment.
Some APIs changed or modularized after Java 11, so if you are using Java 17, ktlint will crash. This will fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Kotlin 1.8.0 the minimum supported Java target is 1.8. This means there is no longer any reason we are setting this in our Realm Plugin. In fact, it might silently modify the behavior of people's compiled code if they are not setting the jvmTarget themselves: https://kotlinlang.org/docs/whatsnew18.html#updated-jvm-compilation-target
I tested this with various combinations of Java (11 and 17) and
build.gradlesettings and it doesn't seem to cause build failures.At the same time, I also unified how we are setting the Kotlin and Java bytecode versions, so they can now all be controlled through our buildSrc Config file.
Regarding the target version, I kept it at 1.8 since we don't know what version of the JVM people are running on the desktop. On Android the minimum the 11, but it didn't seem worth it to try to differentiate the two.
Since we are running Java 11 as a minimum on our developer machines and CI, we could probably set the
sourceCompatibilityto 11 as well, but the confusion didn't seem worth it. Also, we don't really have any Java sources to speak of anyway.